Sugar Labs - User contributions [en]

Development Team/Sugar-Build

2013-01-12T01:46:29Z

Dnarvaez:

[http://git.sugarlabs.org/sugar-build/sugar-build sugar-build] is a set of scripts to make it easy to build all the sugar modules and some of the required dependencies. Please see the [http://sugarlabs.org/~buildbot/docs/build.html documentation].

If you find any issue please report them instead of documenting workarounds on this page. The tips get out of date really quickly and unreported bugs are never fixed. The goal here is to always work out of the box for everyone.

Development Team/Sugar-Build

2012-11-18T09:15:58Z

Dnarvaez:

[http://git.sugarlabs.org/sugar-build/sugar-build sugar-build] is a set of scripts to make it easy to build all the sugar modules and some of the required dependencies. Please see the [http://sugarlabs.org/~dnarvaez/sugar-docs/build.html documentation].

If you find any issue please report them instead of documenting workarounds on this page. The tips get out of date really quickly and unreported bugs are never fixed. The goal here is to always work out of the box for everyone.

Development Team/Sugar-Build

2012-11-18T09:14:19Z

Dnarvaez:

sugar-build is a set of scripts to make it easy to build all the sugar modules and some of the required dependencies. Please see the [documentation http://git.sugarlabs.org/sugar-build/sugar-build].

If you find any issue please report them instead of documenting workarounds on this page. The tips get out of date really quickly and unreported bugs are never fixed. The goal here is to always work out of the box for everyone.

Features/GTK3/Shell

2012-08-24T12:57:19Z

Dnarvaez: /* gtk_clipboard_set_with_data not introspected */

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

It seems like functions with multiple callbacks are still unsupported in pygi. I opened https://bugzilla.gnome.org/show_bug.cgi?id=682604 but unless someone suggest a way to not break API perhaps we should just add our own sugar_clipboard_set_data using closures for now --dnarvaez

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

We have a wrapper for this in sugar-toolkit-gtk3 --dnarvaez

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

Maybe add to gdkwrapper in sugar-toolkit-gtk3? --dnarvaez

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

===key grabber===
 Fix from: Simon Schampijer 
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

=== Xkl.ConfigRec does not have set_model() method ===
 Fix from: Manuel Quiñones, Sergey V. Udaltsov 

This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

Features/GTK3/Shell

2012-08-23T06:47:59Z

Dnarvaez: /* gtk_clipboard_set_with_data not introspected */

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

===key grabber===
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

It seems like functions with multiple callbacks are still unsupported in pygi --dnarvaez

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

We have a wrapper for this in sugar-toolkit-gtk3 --dnarvaez

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

Maybe add to gdkwrapper in sugar-toolkit-gtk3? --dnarvaez

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

=== Xkl.ConfigRec does not have set_model() method ===
 Fix from: Manuel Quiñones, Sergey V. Udaltsov 

This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

Features/GTK3/Shell

2012-08-23T06:44:02Z

Dnarvaez: /* gdk_property_get */

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

===key grabber===
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

We have a wrapper for this in sugar-toolkit-gtk3 --dnarvaez

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

Maybe add to gdkwrapper in sugar-toolkit-gtk3? --dnarvaez

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

=== Xkl.ConfigRec does not have set_model() method ===
 Fix from: Manuel Quiñones, Sergey V. Udaltsov 

This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

Features/GTK3/Shell

2012-08-23T06:43:17Z

Dnarvaez: /* gdk_property_change */

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

===key grabber===
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

We have a wrapper for this in sugar-toolkit-gtk3 --dnarvaez

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

=== Xkl.ConfigRec does not have set_model() method ===
 Fix from: Manuel Quiñones, Sergey V. Udaltsov 

This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

Features/GTK3/Shell

2012-08-23T05:49:37Z

Dnarvaez:

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

===key grabber===
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

=== Xkl.ConfigRec does not have set_model() method ===
 Fix from: Manuel Quiñones, Sergey V. Udaltsov 

This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

Features/GTK3/Shell

2012-08-23T05:43:57Z

Dnarvaez: /* Custom tree model for journal */

Manuq started the port of the shell branching the hippo removal. The main issues were identified by Daniel Drake some months ago and fortunately most of them are fixed at this point.

Daniel Narvaez set up a sugar-build branch to make the port. To test:

git clone git://git.sugarlabs.org/~dnarvaez/sugar-build/manuqs-shell-port.git

That is sugar-build with this sugar components branched:

http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port
http://git.sugarlabs.org/~manuq/sugar-toolkit-gtk3/manuqs-sugar-toolkit-gtk3

==Open==

=== Custom tree model for journal ===

Having trouble reimplementing this. See http://mail.gnome.org/archives/python-hackers-list/2011-December/msg00010.html [https://bugzilla.gnome.org/show_bug.cgi?id=680812 this bug] might be related see 8f31e85db1392eb7222593fc0d05144c2bca06a3 in pygobject.

Gonzalo provided an initial patch, and Manuq worked over it.

Current patch: http://dev.laptop.org/~manuq/journal_gtk3-2.patch

Previous patch that includes the switch to new toolbars: http://dev.laptop.org/~manuq/journal_gtk3.patch .

=== Xkl.ConfigRec does not have set_model() method ===
This should be called in the setup keyboard at the startup. setup_keyboard_cb in sugar/bin/sugar-session . Reported in pygobject as: https://bugzilla.gnome.org/show_bug.cgi?id=681566

Seems that libxklavier needs a setter. Reported to libxklavier as https://bugzilla.freedesktop.org/show_bug.cgi?id=53547

===key grabber===
- grab_keys needs to be introspectable, [http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039190.html patch]
- is_modifier does not allow to pass no mask anymore, has to be something like "is_modifier(keycode, mask=Gdk.ModifierType.MOD1_MASK)"

===gtk_clipboard_set_with_data not introspected===
In the [http://git.gnome.org/browse/gtk+/tree/gtk/gtkclipboard.c#n655 annotations] it is marked as non-introspectable.

http://www.daa.com.au/pipermail/pygtk/2011-July/019940.html

- check with pygobject devs if the above statement is still the case

=== gdk_property_change ===
Is [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11332 marked as non-introspectable] in the annotations.
<pre>
>>> from gi.repository import Gdk
>>> Gdk.property_change
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 266, in __getattr__
return getattr(self._introspection_module, name)
File "/home/erikos/sources/manuqs-shell-port/install/lib/python2.7/site-packages/gi/module.py", line 115, in __getattr__
self.__name__, name))
AttributeError: 'gi.repository.Gdk' object has no attribute 'property_change'
</pre>

=== gdk_property_get ===
The [http://git.gnome.org/browse/gtk+/tree/gdk/gdkwindow.c#n11261 gdk_property_get annotations] mark it as introspectable.

Not working:

<pre>
def _property_get_trapped(window, prop, prop_type):
Gdk.error_trap_push()

prop_atom = Gdk.Atom.intern(prop, False)
type_atom = Gdk.Atom.intern(prop_type, False)

logging.warning("get prop %s %s %s", window, prop_atom, type_atom)
prop_info = Gdk.property_get(window, prop_atom, type_atom, 0, 9999, False)
</pre>

TypeError: Could not caller allocate argument 6 of callable property_get

=== Port hardcoded styles to the CSS stylesheet ===

For example in sugar/extensions/cpsection/network/view.py we have things like:

<pre>
label_server = gtk.Label(_('Server:'))
label_server.set_alignment(1, 0.5)
label_server.modify_fg(gtk.STATE_NORMAL,
style.COLOR_SELECTION_GREY.get_gdk_color())
</pre>

=== Palettes can't include menu and widgets at the same time ===

We can use anything like this:

<pre>

class SugarMenuItem(gtk.EventBox):

__gsignals__ = {
'clicked': (gobject.SIGNAL_RUN_FIRST, None, [])
}

def __init__(self, icon_name, label_text):
gtk.EventBox.__init__(self)
self._sensitive = True
vbox = gtk.VBox()
hbox = gtk.HBox()
vbox.set_border_width(style.DEFAULT_PADDING)
self.icon = Icon()
self.icon.props.icon_name = icon_name
hbox.pack_start(self.icon, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
align = gtk.Alignment(xalign=0.0, yalign=0.5, xscale=0.0, yscale=0.0)
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label = gtk.Label()
self.label.set_use_markup(True)
self.label.set_markup(text)
align.add(self.label)
hbox.pack_start(align, expand=True, fill=True,
padding=style.DEFAULT_PADDING)
vbox.pack_start(hbox, expand=False, fill=False,
padding=style.DEFAULT_PADDING)
self.add(vbox)
self.id_bt_release_cb = self.connect('button-release-event',
self.__button_release_cb)
self.id_enter_notify_cb = self.connect('enter-notify-event',
self.__enter_notify_cb)
self.id_leave_notify_cb = self.connect('leave-notify-event',
self.__leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())
self.show_all()
self.set_above_child(True)

def __button_release_cb(self, widget, event):
self.emit('clicked')

def __enter_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL,
style.COLOR_BUTTON_GREY.get_gdk_color())

def __leave_notify_cb(self, widget, event):
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

def set_icon(self, icon_name):
self.icon.props.icon_name = icon_name

def set_label(self, label_text):
text = '' % style.COLOR_WHITE.get_html() + \
label_text + ''
self.label.set_markup(text)

def set_sensitive(self, sensitive):
if self._sensitive == sensitive:
return

self._sensitive = sensitive
if sensitive:
self.handler_unblock(self.id_bt_release_cb)
self.handler_unblock(self.id_enter_notify_cb)
self.handler_unblock(self.id_leave_notify_cb)
else:
self.handler_block(self.id_bt_release_cb)
self.handler_block(self.id_enter_notify_cb)
self.handler_block(self.id_leave_notify_cb)
self.modify_bg(gtk.STATE_NORMAL, style.COLOR_BLACK.get_gdk_color())

</pre>

And add them to a vbox:

<pre>

# TODO: private!!!
self._content.set_border_width(0)

self._play_pause_button = SugarMenuItem('player_play',
_('Say selected text'))
self._play_pause_button.connect('clicked', self.__play_clicked_cb)
vbox_menu.add(self._play_pause_button)

</pre>

To do the SegurMenuItem take all the width in the palette, we need set the border_width in _content to zero,
but that is a private member. Then we need to look if we add a method to set the it,
or change the api to make the first container (where is the menu today) useful for other type of widgets.

In Manuq branch, palettes are blinking when mouse is over the icon.

AssertionError:

Traceback (most recent call last):
File "/home/manuq/prog/manuqs-shell-port/install/lib/python2.7/site-packages/sugar3/graphics/palette.py", line
or isinstance(self._widget, _PaletteWindowWidget)
AssertionError

=== A handful of NMClient issues ===

See http://mail.gnome.org/archives/python-hackers-list/2011-August/msg00003.html and the other posts in the thread. Some problems resolved, some probably still pending.

===Drag-and-drop in home view, random layout===
Partially done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/204899e21435d12114747127feee2122e6c3efe3 commit 204899e2]. Pending issue: the activity icon is not being displayed while dragging.

(sugar-session:13647): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `site != NULL' failed

===Other issues===
* activity launch icon in the frame does not stop fading in and out, like loading
* widgets like icons and texts have grey background instead of black (toolbar-grey) - this is because of a change in gtk (seen in Browse too)

==Done==

===Owner icon allocation issue===
 Fix from: Simon Schampijer in commit cd29d065.

=== Port the gstreamer code to pygi ===
 Fix from: Daniel Narvaez in commit f74489e6 .

=== Remove resize grips ===
 Fix from: Manuel Quiñones 

Resize grip has been moved from GtkStatusbar to GtkWindow. See "Resize grip" section of the [http://developer.gnome.org/gtk3/3.1/ch25s02.html GTK+2 > GTK+3 porting guide].

Done in [http://git.sugarlabs.org/sugar/manuqs-erikos-shell-port/commit/3efb87f349f56e4167010ac020ad31521e2533a2 commit 3efb87f3].

=== Custom Icon cell renderer ===
 Fix from: Manuel Quiñones 

sugar3.graphics.icon.CellRendererIcon is based on pygtks GenericCellRenderer - needs to be ported

=== gconf_client_get_list not introspectable ===
 Workaround from: Daniel Drake 

The [http://git.gnome.org/browse/gconf/tree/gconf/gconf-client.c#n1838 annotations] mark it as non-introspectale.

opened an upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=681433

similar boxed types fix: https://bugzilla.gnome.org/show_bug.cgi?id=613247

The keyboard is not set up yet because of this as is being called in setup_keyboard_cb in sugar/bin/sugar-session .

Needs:
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/74c77ed68912ec9253f509ba25ff05cebb4fba97
* http://git.sugarlabs.org/~manuq/sugar/manuqs-erikos-shell-port/commit/be519897a1cbd759e4feca640a95317804bedbc0

=== Custom TreeModelSort for home list view ===
 Fix from: Simon Feltman, Manuel Quiñones 

Can't inherit GtkTreeModelSort and pass a model to the parent constructor. Filed as: https://bugzilla.gnome.org/show_bug.cgi?id=681477

Working testcase for pygtk: http://dev.laptop.org/~manuq/test_listmodel2_gtk2.py

Testcase that shows the issue in PyGi: http://dev.laptop.org/~manuq/test_listmodel2_gtk3.py

Needs:
* can be made to work by passing keyword arguments e.g. "Gtk.TreeModelSort.__init__(self, model=self._model_filter)"

=== can't call gdk_window_set_user_data() ===
In the latest implementation we don't use set_user_data anymore AFAIK.
http://mail.gnome.org/archives/python-hackers-list/2011-September/msg00006.html

=== do_forall not working in pygobject ===
 Fix from: Tomeu Vizoso, John Palmieri, Carlos Garnacho 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=663052 gobject-introspection was merged 2012-07-13
* https://bugzilla.gnome.org/show_bug.cgi?id=644926 pygobject missing header file in patch. was merged 2012-03-27
* http://git.gnome.org/browse/gtk+/commit/?id=db569cbee7e3842d802c5f1d53e28d0dde98ffeb fix which landed in GTK+

=== cant call gdkwindow.raise() ===
 Fix from: Martin Pitt 

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=676746 fix landed in pygobject
* use gtk_window.get_window().raise_ instead

=== can not listen to signals in subclassed subclasses ===
 Fix from: Carlos Garnacho 

ActivityIcon.do_draw never called, see http://bugs.sugarlabs.org/ticket/3386

Needs:
* https://bugzilla.gnome.org/show_bug.cgi?id=672864 fix landed in pygobject

=== set_data/get_data not available anymore===
 Fix in toolkit-gtk3 from: Simon Schampijer 

More background info in: https://bugzilla.gnome.org/show_bug.cgi?id=641944

Needs:
* http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/af320f91f800ed9a46e84f12e9aa1ae3b95493b4 we can use python attributes here

=== libxklavier ===
 Fix from: Manuel Quiñones

[http://git.fedorahosted.org/cgit/anaconda.git/tree/pyanaconda/keyboard.py This is] how [http://fedoraproject.org/wiki/Anaconda Anaconda] is using [http://cgit.freedesktop.org/libxklavier/libxklaview libxklavier] in Python (found when coming across [https://bugzilla.redhat.com/show_bug.cgi?id=772664 this bug], Colin [https://mail.gnome.org/archives/commits-list/2012-May/msg00247.html enabled introspection for libxklavier]).

You have to use Xkl.Engine.get_instance(display) [https://bugzilla.gnome.org/show_bug.cgi?id=680202 instead of the constructor]. Manuq made sure the API we use is there. [http://cgit.freedesktop.org/libxklavier/tree/tests/test_gi.py This testcase] was useful.

User talk:Humitos/SugarToolkitDocs

2012-07-05T12:07:24Z

Dnarvaez: Created page with "Just a couple of suggestions. Make it a Makefile target and use a better theme like sphinxdoc :) --dnarvaez"

Just a couple of suggestions. Make it a Makefile target and use a better theme like sphinxdoc :) --dnarvaez

Machine/bender

2012-06-22T08:41:02Z

Dnarvaez: /* Hosted VMs */

<noinclude>{{TOCright}}</noinclude>

== Hostnames ==
* bender.codewiz.org
* bender.sugarlabs.org

== Hardware ==
* Crappy minitower
* Core 2 Duo 1.8GHz
* 6GB RAM
* 2x1TB RAID1, 2x320GB RAID1
* Fedora 13 x86_64

== Location ==
Hosted by [http://www.develer.com/ Develer]

== Admins ==
* [[User:Bernie|Bernie Innocenti]], _bernie on #sugar Freenode
* [[User:dnarvaez|Daniel Narvaez]], dnarvaez on #sugar Freenode
* [[User:sascha_silbe|sascha_silbe]] (silbe on #sugar Freenode)
* Stefano Fedrigo <aleph AT develer.com>, sometimes _aleph on Freenode (local access, office hours CET)
* Develer Infrastructure <it AT lists.develer.com> (local access, office hours CET)

== Network configuration ==

Develer has a 10mbit up/downlink and asks to limit bandwidth usage from hosted services.
There is a traffic shaper, but it may have trouble shaping 6to4 traffic.

Bender is globally accessible through public, static IPv4 as well as the 6to4 subnet associated
to it: 2002:5395:9edc::/48.

The tun6to4 interface on bender is assigned the globally visible address 2002:5395:9edc::1.
The subnet 2002:5395:9edc:1::/64 of our 6to4 net is assigned to the bridge virbr0, which binds together
several virtual interfaces connected to the libvirt guests. With this network setup, IPv6 routing works
naturally, without the need to add any special routing rules on bender.

The virbr0 bridge is created by libvirt on startup with <code>/etc/libvirt/qemu/networks/default.xml</code>.
Libvirt does not yet support assigning IPv6 addresses to bridges, therefore we do this in <code>/etc/rc.local</code>:

ip addr add 2002:5395:9edc:1::1/64 dev virbr0

To automatically configure network and on the gursts, Bender also runs radvd, the IPv6 Routing Advertisement
daemon. The contents of <code>/etc/radvd.conf</code> are:

interface virbr0
{
IgnoreIfMissing on;
AdvSendAdvert on;
MinRtrAdvInterval 30;
MaxRtrAdvInterval 100;
AdvDefaultPreference low;
AdvHomeAgentFlag off;

#bernie: subnet 1 of our /48 6to4 on Develer Consiagnet
prefix 2002:5395:9edc:1::1/64
{
AdvOnLink on;
AdvAutonomous on;
};
};

Guests simply need to be configured to accept IPv6 routing advertisements. The DNS must be assigned manually.

== Hosted VMs ==
All buildslaves currently run off bender as KVM virtual machines managed by libvirtd.

The machines are not globally addressable on IPv4 and are only reachable by IPv6. The
IPv6 address is dynamically configured by radvd to a subnet of the public 6to4 net.

All the VMs are in /srv/images. See the README in the same directory.

They have been created with

virt-install --name buildslave-name --ram 512 \
--disk path=/srv/images/buildslave-name.img,size=10
--network network:default \
--location "mirror-http-address" \
--extra-args="console=tty0 console=ttyS0,115200n8 serial"

Machine/bender

2012-06-22T08:30:12Z

Dnarvaez: /* Admins */

<noinclude>{{TOCright}}</noinclude>

== Hostnames ==
* bender.codewiz.org
* bender.sugarlabs.org

== Hardware ==
* Crappy minitower
* Core 2 Duo 1.8GHz
* 6GB RAM
* 2x1TB RAID1, 2x320GB RAID1
* Fedora 13 x86_64

== Location ==
Hosted by [http://www.develer.com/ Develer]

== Admins ==
* [[User:Bernie|Bernie Innocenti]], _bernie on #sugar Freenode
* [[User:dnarvaez|Daniel Narvaez]], dnarvaez on #sugar Freenode
* [[User:sascha_silbe|sascha_silbe]] (silbe on #sugar Freenode)
* Stefano Fedrigo <aleph AT develer.com>, sometimes _aleph on Freenode (local access, office hours CET)
* Develer Infrastructure <it AT lists.develer.com> (local access, office hours CET)

== Network configuration ==

Develer has a 10mbit up/downlink and asks to limit bandwidth usage from hosted services.
There is a traffic shaper, but it may have trouble shaping 6to4 traffic.

Bender is globally accessible through public, static IPv4 as well as the 6to4 subnet associated
to it: 2002:5395:9edc::/48.

The tun6to4 interface on bender is assigned the globally visible address 2002:5395:9edc::1.
The subnet 2002:5395:9edc:1::/64 of our 6to4 net is assigned to the bridge virbr0, which binds together
several virtual interfaces connected to the libvirt guests. With this network setup, IPv6 routing works
naturally, without the need to add any special routing rules on bender.

The virbr0 bridge is created by libvirt on startup with <code>/etc/libvirt/qemu/networks/default.xml</code>.
Libvirt does not yet support assigning IPv6 addresses to bridges, therefore we do this in <code>/etc/rc.local</code>:

ip addr add 2002:5395:9edc:1::1/64 dev virbr0

To automatically configure network and on the gursts, Bender also runs radvd, the IPv6 Routing Advertisement
daemon. The contents of <code>/etc/radvd.conf</code> are:

interface virbr0
{
IgnoreIfMissing on;
AdvSendAdvert on;
MinRtrAdvInterval 30;
MaxRtrAdvInterval 100;
AdvDefaultPreference low;
AdvHomeAgentFlag off;

#bernie: subnet 1 of our /48 6to4 on Develer Consiagnet
prefix 2002:5395:9edc:1::1/64
{
AdvOnLink on;
AdvAutonomous on;
};
};

Guests simply need to be configured to accept IPv6 routing advertisements. The DNS must be assigned manually.

== Hosted VMs ==
All buildslaves currently run off bender as KVM virtual machines managed by libvirtd.

The machines are not globally addressable on IPv4 and are only reachable by IPv6. The
IPv6 address is dynamically configured by radvd to a subnet of the public 6to4 net.
Please remember to update the sugarlanbs.org zone when adding new build slaves.
{{Special:PrefixIndex/{{PAGENAME}}/}}

[[Category:Machine]]