Karma/Anti-conventions - Revision history

BryanWB: /* Putting style information inline */

2010-01-18T12:22:17Z

Putting style information inline

← Older revision		Revision as of 08:22, 18 January 2010
Line 31:		Line 31:
	</nowiki>		</nowiki>

	This makes the lesson much harder to debug as you have to look both in the .css file		This makes the lesson much harder to debug as you have to look both in the .css file
	and at the html. As the lesson grows, which it will, it gets harder and harder to		and at the html. As the lesson grows, which it will, it gets harder and harder to
	pin down small bugs		pin down small bugs

	==Mixing naming conventions, like camelCase and not_camel_case==		==Mixing naming conventions, like camelCase and not_camel_case==

BryanWB: /* Manually constructing an html sequence rather than passing a string */

2010-01-18T12:21:48Z

Manually constructing an html sequence rather than passing a string

← Older revision		Revision as of 08:21, 18 January 2010
Line 20:		Line 20:
	.text('hello world');		.text('hello world');

	According to jQuery Cookbook this is much, much faster		According to jQuery Cookbook this is much, much faster
	<nowiki>		<nowiki>
	$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>'));		$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>'));
	</nowiki>		</nowiki>
	FYI, prefixing cached jQuery reference w/ a "$" is a good practice.		FYI, prefixing cached jQuery reference w/ a "$" is a good practice.


	==Putting style information inline==		==Putting style information inline==
	<nowiki>		<nowiki>

BryanWB at 12:20, 18 January 2010

2010-01-18T12:20:41Z

← Older revision		Revision as of 08:20, 18 January 2010
Line 1:		Line 1:
	~~'''~~Not closing <img /> or <meta /> tags~~.'''~~		==Not closing <img /> or <meta /> tags==

	You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly.		You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly.
	~~<br />~~
			==Using document.write()==
	<nowiki>		<nowiki>
	Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>');		Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>');
	</nowiki>		</nowiki>
			<br />
	<br />		<br />
	document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.		document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.

	Manually constructing an html sequence rather than passing a string.		==Manually constructing an html sequence rather than passing a string==

	The former is not incorrect per se, but it is much, much slower than passing a string to .html(), at least according to the jQuery Cookbook.		The former is not incorrect per se, but it is much, much slower than passing a string to .html(), at least according to the jQuery Cookbook.
Line 19:		Line 21:

	According to jQuery Cookbook this is much, much faster		According to jQuery Cookbook this is much, much faster
			<nowiki>
	$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>'));		$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>'));
			</nowiki>
	FYI, prefixing cached jQuery reference w/ a "$" is a good practice.		FYI, prefixing cached jQuery reference w/ a "$" is a good practice.


	Putting style information inline		==Putting style information inline==
			<nowiki>
	<div style="display:none;"> </div>		<div style="display:none;"> </div>
			</nowiki>

	This makes the lesson much harder to debug as you have to look both in the .css file		This makes the lesson much harder to debug as you have to look both in the .css file
Line 33:		Line 36:
	pin down small bugs		pin down small bugs

	Mixing naming conventions, like camelCase and not_camel_case		==Mixing naming conventions, like camelCase and not_camel_case==

	Neither of these naming conventions is the "correct" convention but mixing them makes it hard for others to work w/ your code		Neither of these naming conventions is the "correct" convention but mixing them makes it hard for others to work w/ your code
			<nowiki>
	<div id="topbtn_right"> would be better written as <div id="topBtnRight">		<div id="topbtn_right"> would be better written as <div id="topBtnRight">
			</nowiki>

BryanWB at 12:18, 18 January 2010

2010-01-18T12:18:33Z

← Older revision		Revision as of 08:18, 18 January 2010
Line 1:		Line 1:
	Not closing <img /> or <meta /> tags.		'''Not closing <img /> or <meta /> tags.'''

	You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly.		You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly.

BryanWB at 12:17, 18 January 2010

2010-01-18T12:17:34Z

← Older revision		Revision as of 08:17, 18 January 2010
Line 1:		Line 1:
	Not closing <img /> or <meta /> tags.		Not closing <img /> or <meta /> tags.

	You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are ~~childrent~~ rather than siblings and display them accordingly.		You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly.
			<br />
	<nowiki>		<nowiki>
	Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>');		Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>');
	</nowiki>		</nowiki>
			<br />
	document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.		document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.

BryanWB at 12:14, 18 January 2010

2010-01-18T12:14:21Z

← Older revision		Revision as of 08:14, 18 January 2010
Line 2:		Line 2:

	You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are childrent rather than siblings and display them accordingly.		You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are childrent rather than siblings and display them accordingly.
			<nowiki>
	Using document.write('<div> some html </div>'); instead of $('#parentDiv').html('<div> some html </div>');		Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>');
			</nowiki>
	document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.		document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.

BryanWB: Created page with 'Not closing or tags. You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close…'

2010-01-18T12:03:59Z

Created page with 'Not closing <img /> or <meta /> tags. You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close…'

New page

Not closing <img /> or <meta /> tags.

You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are childrent rather than siblings and display them accordingly.

Using document.write('<div> some html </div>'); instead of $('#parentDiv').html('<div> some html </div>');

document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page.

Manually constructing an html sequence rather than passing a string.

The former is not incorrect per se, but it is much, much slower than passing a string to .html(), at least according to the jQuery Cookbook.

$parent = $(document.createElement('div'))
.appendTo('#someId')
.attr({id: 'foo', class: 'foobar baz'})
.text('hello world');

According to jQuery Cookbook this is much, much faster

$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>'));

FYI, prefixing cached jQuery reference w/ a "$" is a good practice.

Putting style information inline

<div style="display:none;"> </div>

This makes the lesson much harder to debug as you have to look both in the .css file
and at the html. As the lesson grows, which it will, it gets harder and harder to
pin down small bugs

Mixing naming conventions, like camelCase and not_camel_case

Neither of these naming conventions is the "correct" convention but mixing them makes it hard for others to work w/ your code

<div id="topbtn_right"> would be better written as <div id="topBtnRight">