Karma/Anti-conventions: Difference between revisions
No edit summary |
No edit summary |
||
| Line 1: | Line 1: | ||
==Not closing <img /> or <meta /> tags== | |||
You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly. | You can usually get away with not closing these tags but they could cause weird rendering of elements that follow them. If you don't close <img>, the browser might think that any following elements are children rather than siblings and display them accordingly. | ||
==Using document.write()== | |||
<nowiki> | <nowiki> | ||
Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>'); | Using document.write('<div>some html</div>'); instead of $('#parentDiv').html('<div> some html </div>'); | ||
</nowiki> | </nowiki> | ||
<br /> | |||
<br /> | <br /> | ||
document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page. | document.write is just bad in general. Some browsers don't like it (chromium) and in all browsers it freezes all other execution while it is writing to the page. | ||
Manually constructing an html sequence rather than passing a string | ==Manually constructing an html sequence rather than passing a string== | ||
The former is not incorrect per se, but it is much, much slower than passing a string to .html(), at least according to the jQuery Cookbook. | The former is not incorrect per se, but it is much, much slower than passing a string to .html(), at least according to the jQuery Cookbook. | ||
| Line 19: | Line 21: | ||
According to jQuery Cookbook this is much, much faster | According to jQuery Cookbook this is much, much faster | ||
<nowiki> | |||
$parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>')); | $parent = $('#someId').append($('<div id="foo" class="foobar baz">Hello World</div>')); | ||
</nowiki> | |||
FYI, prefixing cached jQuery reference w/ a "$" is a good practice. | FYI, prefixing cached jQuery reference w/ a "$" is a good practice. | ||
Putting style information inline | ==Putting style information inline== | ||
<nowiki> | |||
<div style="display:none;"> </div> | <div style="display:none;"> </div> | ||
</nowiki> | |||
This makes the lesson much harder to debug as you have to look both in the .css file | This makes the lesson much harder to debug as you have to look both in the .css file | ||
| Line 33: | Line 36: | ||
pin down small bugs | pin down small bugs | ||
Mixing naming conventions, like camelCase and not_camel_case | ==Mixing naming conventions, like camelCase and not_camel_case== | ||
Neither of these naming conventions is the "correct" convention but mixing them makes it hard for others to work w/ your code | Neither of these naming conventions is the "correct" convention but mixing them makes it hard for others to work w/ your code | ||
<nowiki> | |||
<div id="topbtn_right"> would be better written as <div id="topBtnRight"> | <div id="topbtn_right"> would be better written as <div id="topBtnRight"> | ||
</nowiki> | |||