Development Team/Code Review: Difference between revisions
Sascha silbe (talk | contribs) add section about maintainer-side process, mentioning Patchwork and Trac |
Sascha silbe (talk | contribs) →Discussion: mention Tested-By: |
||
| Line 76: | Line 76: | ||
If a reviewer thinks your patch is good (and revelant) enough to be included in the upstream version of the software, (s)he will grant his or her Reviewed-By: tag (see the [http://www.kernel.org/doc/Documentation/SubmittingPatches Linux patch submission process] for details). | If a reviewer thinks your patch is good (and revelant) enough to be included in the upstream version of the software, (s)he will grant his or her Reviewed-By: tag (see the [http://www.kernel.org/doc/Documentation/SubmittingPatches Linux patch submission process] for details). | ||
Similarly, everyone is encouraged to try out your patch and give their Tested-By: tag if it worked well for them. | |||
After you addressed review comments, you can submit a new version of your patch (see [[#Patch submission|above]] for how to note what you changed). Please make it a reply to your original patch by using the <code>[http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html#_options --in-reply-to]</code> option to <code>git send-email</code>. E.g.: <code>git send-to-ml-single --in-reply-to=<1290857483.723474@twin.sascha.silbe.org></code> | After you addressed review comments, you can submit a new version of your patch (see [[#Patch submission|above]] for how to note what you changed). Please make it a reply to your original patch by using the <code>[http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html#_options --in-reply-to]</code> option to <code>git send-email</code>. E.g.: <code>git send-to-ml-single --in-reply-to=<1290857483.723474@twin.sascha.silbe.org></code> | ||