Features/GTK3/Shell/Hippo Removal: Difference between revisions

Manuq (talk | contribs)
No edit summary
 
Line 33: Line 33:
Implementation: In the Neighborhood view we use the [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/desktop/favoriteslayout.py#line143 SpreadLayout] to position the icons. All the icons are part of the grid in order to do collision detection. We use the exiting [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/desktop/snowflakelayout.py snowflakelayout] to do the grouping of the buddy icons around an activity.
Implementation: In the Neighborhood view we use the [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/desktop/favoriteslayout.py#line143 SpreadLayout] to position the icons. All the icons are part of the grid in order to do collision detection. We use the exiting [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/desktop/snowflakelayout.py snowflakelayout] to do the grouping of the buddy icons around an activity.


===Journal Detail View===
To get back the layout of the Journal Detail View a few things have been done.  However we should look forward to do them with CSS in GTK+3.  They are:
* Setting the background color of the [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/journal/expandedentry.py#line61 ExpandedEntry] is done wrapping the container inside a gtk.EventBox as explained [http://www.pygtk.org/docs/pygtk/class-gtkwidget.html#method-gtkwidget--modify-bg here].
* Setting the paddings of the different widgets is done wrapping them inside gtk.Aligment widgets. Example [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port/blobs/master/src/jarabe/journal/expandedentry.py#line73 here].  Paddings were managed before using hippo.CanvasBox.
As said above, the intermediary code could be simplified after the switch to GTK+3.  Today seems not possible, but should be doable in the future.  There is a bug filed upstream: https://bugzilla.gnome.org/show_bug.cgi?id=678790


* [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port shell port repository]
* [http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port shell port repository]