Talk:Development Team/Code Review: Difference between revisions

(One intermediate revision by the same user not shown)

Line 32:

Feel free to improve the above text directly in the talk page. Add a watch to this

page to note changes made by others.

== Revised patches ==

''add a version number to the subject prefix (e.g. git send-email --subject-prefix="PATCH v2 sugar")''

Sounds inpractical and needles complicated, from one point all email clients support thread, from another point, with mail basis patch tracking (using only email client) there is no way to have thread status.

If patch tracking systems can't detect current status w/o setting subjects it needs to be fixed, otherwise it becomes annoying from patch submitter pov.

''v1->v2:'' also might be questionable, having it in git log is useless (since the full story is in email thread). At the same time, if there is a need out-of-git-log comments, it might happen in --compose mode.

@@ Line 32: / Line 32: @@
 Feel free to improve the above text directly in the talk page. Add a watch to this
 page to note changes made by others.
+== Revised patches ==
+''add a version number to the subject prefix (e.g. git send-email --subject-prefix="PATCH v2 sugar")''
+Sounds inpractical and needles complicated, from one point all email clients support thread, from another point, with mail basis patch tracking (using only email client) there is no way to have thread status.
+If patch tracking systems can't detect current status w/o setting subjects it needs to be fixed, otherwise it becomes annoying from patch submitter pov.
+''v1->v2:'' also might be questionable, having it in git log is useless (since the full story is in email thread). At the same time, if there is a need out-of-git-log comments, it might happen in --compose mode.