Features/GTK3/Porting/GetBooks: Difference between revisions

Humitos (talk | contribs)
Humitos (talk | contribs)
Line 12: Line 12:
# Follow the [[Development_Team/Code_guidelines|Code Guidelines]] during all the porting process
# Follow the [[Development_Team/Code_guidelines|Code Guidelines]] during all the porting process
# Remove all things related with '''old toolbar''' support. They are no longer maintained
# Remove all things related with '''old toolbar''' support. They are no longer maintained
# Write comments on the code, by adding "# README:", "# TODO:" and "# FIXME" explaining what are the problems that you are having with that chunk of code. Put a link if it's necessary
# Write comments on the code, by adding '''# README:''', '''# TODO:''' and '''# FIXME:''' explaining what are the problems that you are having with that chunk of code. Put a link if it's necessary
# If you are considering to fix some ''pep8'' or ''pylint'' errors/warnings, please create two separate patch files (one for the port and one for the pylint/pep8 changes). If we follow this way it is easier to check the port patches, if not the information about the port itself it's difficult to follow
# If you are considering to fix some ''pep8'' or ''pylint'' errors/warnings, please create two separate patch files (one for the port and one for the pylint/pep8 changes). If we follow this way it is easier to check the port patches, if not the information about the port itself it's difficult to follow
# Keep reading this wiki page to find out more things that you should do
# Keep reading this wiki page to find out more things that you should do