Changes

1,698 bytes added ,  20:20, 24 April 2017
no edit summary
Line 10: Line 10:     
== Summary ==
 
== Summary ==
Add a setting for a Save-As dialog to interrupt the activity Stop workflow if a name has not been set for the journal entry.
+
Provides the 'save' and 'save as' capabilities common to document processing applications.
    
== Owner ==
 
== Owner ==
Line 19: Line 19:  
* Targeted release: 0.112
 
* Targeted release: 0.112
 
* Last updated: 24th April 2017
 
* Last updated: 24th April 2017
* Percentage of completion: 80%
+
* Percentage of completion: complete
    
== Detailed Description ==
 
== Detailed Description ==
* add a setting ''save-as'',
+
* for a new document (start new), when the user quits the activity, a popup provides an opportunity for the user to give the document a name. The user can also decide not to save it.
* when an activity stop button is pressed, and the journal entry has not been named, and when ''save-as'' is set, prompt for the name,
+
* for an existing document, when the user quits the activity, a popup provides an opportunity to give it a new name. In this case, it will be saved under the new name and the original will be preserved. If the user chooses not to provide a new name, the document is saved replacing the original.
* fix any activities that are broken by the change,
+
* provides a setting to enable or disable the feature
* also backport to GTK+ 2 toolkit,
      
== Benefit to Sugar ==
 
== Benefit to Sugar ==
 
''What is the benefit to the platform?  If this is a major capability update, what has changed?  If this is a new feature, what capabilities does it bring? Why will Sugar become a better platform or project because of this feature?''
 
''What is the benefit to the platform?  If this is a major capability update, what has changed?  If this is a new feature, what capabilities does it bring? Why will Sugar become a better platform or project because of this feature?''
   −
Force rather than passively encourage reflection.
+
Currently Sugar saves objects to the Journal with the name of the activity. In the original toolkit design, the name was displayed to the top left of the toolbar so that a user could enter their own name. At that time, the user had a 'keep' button on the toolbar which enabled an object to be saved while continuing to work as found on most document based applications.
 +
 
 +
Currently, there is no keep button because Sugar does that automatically. This change comes with a serious flaw. Sugar uses the existing jobject when an activity is opened so that the original is overwritten. For example, a TurtleBlocks program could be resumed and the user decide to do a new program. His previous program is lost.
 +
 
 +
With this feature, the activity creates a new object cloned from the original. If the user saves the document (Turtle Blocks program) under a different name, the original remains in the Journal.
 +
If the name is not changed, the object replaces the original.
 +
 
 +
This feature is modeled on the behavior of the 'save' and 'save as' feature of conventional document handling programs.
    
''Make sure to note here as well if this feature has been requested by a specific deployment, or if it has emerged from a bug report.''
 
''Make sure to note here as well if this feature has been requested by a specific deployment, or if it has emerged from a bug report.''
   −
Requested by Tony Anderson.
+
Requested by Tony Anderson. Implemented by Utkarsh Tiwari as part of GSOC 2016.
    
== Scope ==
 
== Scope ==
Line 40: Line 46:  
''What work do the developers have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?''
 
''What work do the developers have to accomplish to complete the feature in time for release?  Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?''
   −
* GSettings schema, see https://github.com/sugarlabs/sugar/pull/750,
+
Feature is implemented in activity.py (sugar and sugar3).  
* GTK+ 3 toolkit activity stop flow, see https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327,
+
A gsetting was added to make enabling the feature optional.
* GTK+ 2 toolkit activity stop flow, see https://github.com/sugarlabs/sugar-toolkit/pull/4,
  −
* Help activity [documentation], not started,
  −
* Browse activity [identified regression], see https://github.com/sugarlabs/browse-activity/pull/49,
      
==UI Design==
 
==UI Design==
Line 54: Line 57:  
== How To Test ==
 
== How To Test ==
 
{{:{{PAGENAME}}/Testing}}
 
{{:{{PAGENAME}}/Testing}}
 +
 
== User Experience ==
 
== User Experience ==
 
''If this feature is noticeable by its target audience, how will their experiences change as a result?  Describe what they will see or notice.''
 
''If this feature is noticeable by its target audience, how will their experiences change as a result?  Describe what they will see or notice.''
   −
A save-as dialog will appear if the journal entry is not named.
+
When the user presses the stop button or ctrl + q, a dialog will appear giving the opportunity to name or rename the associated Journal entry.
 +
 
 +
The user can chose not to save the object.
 +
 
 +
If the document has been resumed from the Journal or the Home View, the user will be able to supply a new name so that this entry is added to the Journal instead of overwriting the original.
    
== Dependencies ==
 
== Dependencies ==
Line 71: Line 79:     
''Is there upstream documentation on this feature, or notes you have written yourself?  Has this topic been discussed in the mailing list or during a meeting? Link to that material here so other interested developers can get involved.''
 
''Is there upstream documentation on this feature, or notes you have written yourself?  Has this topic been discussed in the mailing list or during a meeting? Link to that material here so other interested developers can get involved.''
 +
 +
See PR #327 at https://github.com/sugarlabs/sugar-toolkit-gtk3
    
== Release Notes ==
 
== Release Notes ==
    
''The Sugar Release Notes inform end-users about what is new in the release. An Example is [[0.84/Notes]]. The release notes also help users know how to deal with platform changes such as ABIs/APIs, configuration or data file formats, or upgrade concerns.  If there are any such changes involved in this feature, indicate them here.  You can also link to upstream documentation if it satisfies this need.  This information forms the basis of the release notes edited by the release team and shipped with the release.''
 
''The Sugar Release Notes inform end-users about what is new in the release. An Example is [[0.84/Notes]]. The release notes also help users know how to deal with platform changes such as ABIs/APIs, configuration or data file formats, or upgrade concerns.  If there are any such changes involved in this feature, indicate them here.  You can also link to upstream documentation if it satisfies this need.  This information forms the basis of the release notes edited by the release team and shipped with the release.''
 +
 +
Save As
 +
 +
A user or deployment can enable this feature by setting gsetting 'save as' to True). This feature provides a capability comparable to the 'save' and 'save as' capabilities offered by conventional document processing programs such as those of Libre Office.
 +
    
== Comments and Discussion ==
 
== Comments and Discussion ==
184

edits