Changes

Jump to navigation Jump to search
Line 47: Line 47:  
* and generate a patch
 
* and generate a patch
 
  git diff -U > patch
 
  git diff -U > patch
* and send the patch to the maintainer for review
+
* and send the patch to the maintainer (Brian Silverman) for review
 
   mailto:bss...
 
   mailto:bss...
* I am waiting for his feedback...
+
* The maintainer made one suggestion:
 +
all looks good to me.
 +
 +
One question. Are you sure you want the "int" of the answer? In the Java version everything is a float, and even in the python version xcor, ycor, and friends are floats. None of the calculations assume ints I don't think.
 +
* I made the change and did some more testing.
 +
 
 +
    defprim(lc,'sqrt', 1, lambda lc,x: sqrt(x))
 +
* next: submit the patch
    
==The patch==
 
==The patch==

Navigation menu