Development Team/Code Review: Difference between revisions

TimClicks (talk | contribs)
m Proposal: effected -> affected
Tomeu (talk | contribs)
Line 24: Line 24:
== Proposal ==
== Proposal ==


* Create your patch using the 'git format-patch' command. (<code>git format-patch HEAD^</code> will create a 00xx-blahblah.patch for every commit. So don't forget to git commit!!)
* If your patch addresses an issue which is not registered in [https://bugs.sugarlabs.org the Sugar Labs trac instance], please open a new ticket for it.
* If your patch addresses an issue which is not registered in [https://bugs.sugarlabs.org the Sugar Labs trac instance], please open a new ticket for it.
* Create your patch using the 'git format-patch' command. (<code>git format-patch HEAD^</code> will create a 00xx-blahblah.patch for every commit. So don't forget to git commit!!) Make sure you mention the ticket number in the commit comment.
* Attach the patch to the ticket
* Attach the patch to the ticket
* Alternatively, you can add a link pointing to a cloned tree. Make sure it contains only the changes you propose for review.
* Alternatively, you can add a link pointing to a cloned tree. Make sure it contains only the changes you propose for review.