Phabricator: Difference between revisions

Rgs (talk | contribs)
Created page with "We've got a test instance of [http://www.phabricator.org Phabricator] running here: [http://phabricator.itevenworks.net http://phabricator.itevenworks.net] Right now you can..."
 
Rgs (talk | contribs)
No edit summary
Line 17: Line 17:
[http://phabricator.itevenworks.net/maniphest/ http://phabricator.itevenworks.net/maniphest/]
[http://phabricator.itevenworks.net/maniphest/ http://phabricator.itevenworks.net/maniphest/]


== Requesting code reviews ==
== Using Phabricator from the command-line ==


A code review in Phabricator is called a Revision. You can create and close revisions directly from the command line via '''arc'''.
A code review in Phabricator is called a Revision. You can create and close revisions directly from the command line via '''arc'''.
Line 42: Line 42:
As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step.
As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step.


=== Using arc ===
=== Create revisions ===


To create a new revision (a code review request) hack on something and create a commit and then:
To create a new revision (a code review request) hack on something and create a commit and then:
Line 48: Line 48:
   arc diff
   arc diff


Once that revision has been approved you can:
If you are requested changes on that revision as part of the code review you can hack on those changes and then:
 
  git commit -a --amend
 
and then request a new review:
 
  arc diff
 
Note that this last command won't create a new revision - it'll update the existing one.
 
Once your reviewers are finally happy with that revision and it has been approved you can close it with:


   arc amend && git push
   arc amend && git push