Phabricator: Difference between revisions

(5 intermediate revisions by the same user not shown)

Line 1:

We've got a test instance of [http://www.phabricator.org Phabricator] running here:

We've got a test instance of [http://www.phabricator.org Phabricator] running here (at the moment I did in my VM because I was testing out the setup - didn't want to do it in sunjammer just yet - will move to a proper SL domain later today/tomorrow):

[http://phabricator.itevenworks.net http://phabricator.itevenworks.net]

== Phabricator's Web UI ==

Right now you can login by creating a regular account or via an FB account (support for other external systems coming soon).

Line 17:

Line 19:

[http://phabricator.itevenworks.net/maniphest/ http://phabricator.itevenworks.net/maniphest/]

== ~~Requesting code reviews~~ ==

== Using Phabricator from the command-line ==

A code review in Phabricator is called a Revision. You can create and close revisions directly from the command line via '''arc'''.

Line 40:

Line 42:

}

As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step.

As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step. The first time you run an arc command against the Phabricator instance it'll ask you to paste in an auth token to validate your account.

When you create a commit you need to include certain fields (reviewer, test plan, etc) so that arc can create a revision out of this. To avoid having to do this manually you can use git commit message templates:

git config --global commit.template ~/.gitmessage.txt

And ~/.gitmessage.txt has to be:

=== ~~Using arc~~ ===

Summary:

Test Plan:

Reviewers:

CC:

=== Create revisions ===

To create a new revision (a code review request) hack on something and create a commit and then:

Line 48:

Line 66:

arc diff

Once that revision has been approved you can:

If you are requested changes on that revision as part of the code review you can hack on those changes and then:

git commit -a --amend

and then request a new review:

arc diff

Note that this last command won't create a new revision - it'll update the existing one.

Once your reviewers are finally happy with that revision and it has been approved you can close it with:

arc amend && git push

@@ Line 1: / Line 1: @@
-We've got a test instance of [http://www.phabricator.org Phabricator] running here:
+We've got a test instance of [http://www.phabricator.org Phabricator] running here (at the moment I did in my VM because I was testing out the setup - didn't want to do it in sunjammer just yet - will move to a proper SL domain later today/tomorrow):
 [http://phabricator.itevenworks.net http://phabricator.itevenworks.net]
+== Phabricator's Web UI ==
 Right now you can login by creating a regular account or via an FB account (support for other external systems coming soon).
@@ Line 17: / Line 19: @@
 [http://phabricator.itevenworks.net/maniphest/ http://phabricator.itevenworks.net/maniphest/]
-== Requesting code reviews ==
+== Using Phabricator from the command-line ==
 A code review in Phabricator is called a Revision. You can create and close revisions directly from the command line via '''arc'''.
@@ Line 40: / Line 42: @@
    }
-As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step.
+As projects pick up Phabricator & arc I am expecting them to have a .arcconfig committed to their repos, so you'll be able to skip this step. The first time you run an arc command against the Phabricator instance it'll ask you to paste in an auth token to validate your account.
+When you create a commit you need to include certain fields (reviewer, test plan, etc) so that arc can create a revision out of this. To avoid having to do this manually you can use git commit message templates:
+  git config --global commit.template ~/.gitmessage.txt
+And ~/.gitmessage.txt has to be:
-=== Using arc ===
+  <Replace this line with a title. 1 line only, 67 chars or less>
+  Summary:
+  Test Plan:
+  Reviewers:
+  CC:
+=== Create revisions ===
 To create a new revision (a code review request) hack on something and create a commit and then:
@@ Line 48: / Line 66: @@
    arc diff
-Once that revision has been approved you can:
+If you are requested changes on that revision as part of the code review you can hack on those changes and then:
+  git commit -a --amend
+and then request a new review:
+  arc diff
+Note that this last command won't create a new revision - it'll update the existing one.
+Once your reviewers are finally happy with that revision and it has been approved you can close it with:
    arc amend && git push