Development Team/Code Review: Difference between revisions
| Line 59: | Line 59: | ||
* Make sure the submitter provided a testcase before approving the patch. | * Make sure the submitter provided a testcase before approving the patch. | ||
* Make sure that [[DevelopmentTeam/API policy|API policy]] rules are respected. | * Make sure that [[DevelopmentTeam/API policy|API policy]] rules are respected. | ||
* Keep an eye on readability, we are roughly following Guido's [http://www.python.org/dev/peps/pep-0008 PEP 8] | |||
* Change the r? keyword to r- to indicate that the patch needs work. | * Change the r? keyword to r- to indicate that the patch needs work. | ||
* Change the r? keyword to r+ if the patch is ok to be pushed. | * Change the r? keyword to r+ if the patch is ok to be pushed. | ||