Development Team/Code Review: Difference between revisions
Sascha silbe (talk | contribs) →Patch guidelines: make clear that pylintrc is included with sugar-jhbuild |
Sascha silbe (talk | contribs) →Patch guidelines: add reference to PEP8 |
||
| Line 18: | Line 18: | ||
== Patch guidelines == | == Patch guidelines == | ||
Please try to use [http://www.logilab.org/857 pylint] to verify your patch for things like exceeding 80 columns etc, unused imports and unused variables. Pylint is not a tool you can rely on 100% but it helps to follow some guidelines and to avoid the most stupid errors like typos. sugar-jhbuild contains a pylintrc you can use in the <code>scripts/data</code> directory: [http://git.sugarlabs.org/projects/sugar-jhbuild/repos/mainline/blobs/master/scripts/data/pylintrc pylintrc] (follow "raw blob data") | Please try to use [http://www.logilab.org/857 pylint] to verify your patch for things like exceeding 80 columns etc, unused imports and unused variables. Pylint is not a tool you can rely on 100% but it helps to follow some guidelines and to avoid the most stupid errors like typos. sugar-jhbuild contains a pylintrc you can use in the <code>scripts/data</code> directory: [http://git.sugarlabs.org/projects/sugar-jhbuild/repos/mainline/blobs/master/scripts/data/pylintrc pylintrc] (follow "raw blob data") | ||
[http://svn.browsershots.org/trunk/devtools/pep8/pep8.py pep8.py] catches more style errors than pylint, so make sure to run that one, too. | |||
In the sugar packages use 'make distcheck' to make sure all files are included and the POTFILES.in is up to date. | In the sugar packages use 'make distcheck' to make sure all files are included and the POTFILES.in is up to date. | ||