Development Team/Code Review: Difference between revisions

Marcopg (talk | contribs)
No edit summary
Line 43: Line 43:
If your patch is a new feature and reasonably big, you may prefer to submit it for review to the Sugar [http://lists.laptop.org/listinfo/sugar mailing list].
If your patch is a new feature and reasonably big, you may prefer to submit it for review to the Sugar [http://lists.laptop.org/listinfo/sugar mailing list].


== Email guidelines ==
In order to make it easy for the reviewer please:
In order to make it easy for the reviewer please include in your email:


* prefix your email title with [PATCH]
* try to make in the title clear what the patch is about
* note which module is effected e.g. sugar, sugar-toolkit...
* note which module is effected e.g. sugar, sugar-toolkit...
* note possible dependencies e.g. the patch is for sugar but depend on the current HEAD of sugar-toolkit which went in 5 seconds ago
* note possible dependencies e.g. the patch is for sugar but depend on the current HEAD of sugar-toolkit which went in 5 seconds ago
* note how the patch can be verified / a use case


== Reviewer guidelines ==
== Reviewer guidelines ==
Please review the overall design of the patch. In many cases a detailed review is welcome as well.
Please review the overall design of the patch. In many cases a detailed review is welcome as well.