Development Team/Code Review: Difference between revisions

Line 43:

== Discussion ==

Maintainers and peers of the Sugar modules periodically check the review queue in Trac. If a few day ~~passes~~ without comment since the patch was submitted, please ping the maintainer in IRC or in the mailing list. At times maintainers are very busy and will appreciate the ping, even if repeated.

Maintainers and peers of the Sugar modules periodically check the review queue in Trac. If a few day pass without comment since the patch was submitted, please ping the maintainer in IRC or in the mailing list. At times maintainers are very busy and will appreciate the ping, even if repeated.

The reviewer will read your patch, evaluate its impact to the existing code base and comment on it. The 'r?' keyword will be changed to 'r+' if the patch is accepted, or to 'r-' if further information or action is requested from the submitter.

The reviewer will read your patch, evaluate its impact to the existing code base and comment on it. The 'r?' keyword will be changed to 'r+' if the patch is accepted, to 'r!' if further information or action is requested from the submitter, or to 'r-' if the patch gets rejected.

~~Note that if your patch is marked with 'r-' it doesn't mean that your code or ideas are bad, just that the maintainer is still not convinced that the patch can be accepted in its current state.~~ See [[Development Team/Code guidelines|Code guidelines]] for common criteria for code in Sugar.

See [[Development Team/Code guidelines|Code guidelines]] for common criteria for code in Sugar.

Once you have answered the questions and/or attached a new patch, set the 'r-' keyword back to 'r?'.

Once you have answered the questions and/or attached a new patch, set the 'r!' keyword back to 'r?'.

== Acceptance ==

@@ Line 43: / Line 43: @@
 == Discussion ==
-Maintainers and peers of the Sugar modules periodically check the review queue in Trac. If a few day passes without comment since the patch was submitted, please ping the maintainer in IRC or in the mailing list. At times maintainers are very busy and will appreciate the ping, even if repeated.
+Maintainers and peers of the Sugar modules periodically check the review queue in Trac. If a few day pass without comment since the patch was submitted, please ping the maintainer in IRC or in the mailing list. At times maintainers are very busy and will appreciate the ping, even if repeated.
-The reviewer will read your patch, evaluate its impact to the existing code base and comment on it. The 'r?' keyword will be changed to 'r+' if the patch is accepted, or to 'r-' if further information or action is requested from the submitter.
+The reviewer will read your patch, evaluate its impact to the existing code base and comment on it. The 'r?' keyword will be changed to 'r+' if the patch is accepted, to 'r!' if further information or action is requested from the submitter, or to 'r-' if the patch gets rejected.
-Note that if your patch is marked with 'r-' it doesn't mean that your code or ideas are bad, just that the maintainer is still not convinced that the patch can be accepted in its current state. See [[Development Team/Code guidelines|Code guidelines]] for common criteria for code in Sugar.
+See [[Development Team/Code guidelines|Code guidelines]] for common criteria for code in Sugar.
-Once you have answered the questions and/or attached a new patch, set the 'r-' keyword back to 'r?'.
+Once you have answered the questions and/or attached a new patch, set the 'r!' keyword back to 'r?'.
 == Acceptance ==