Activities/Turtle Art/Patching: Difference between revisions
| Line 52: | Line 52: | ||
:(I also made corresponding changes in the images/es and images/fr trees) | :(I also made corresponding changes in the images/es and images/fr trees) | ||
* I made an .xo bundle so I could let other people easily install and test my changes | * I made an .xo bundle so I could let other people easily install and test my changes | ||
zip -r turtleart.xo turtleart-activity | |||
* and generate a patch | * and generate a patch | ||
git diff -U > patch | git diff -U > patch | ||
* and sent the patch to the maintainer (Brian Silverman) for review | * and sent the patch to the maintainer (Brian Silverman) for review | ||
mailto:bss... | |||
* The maintainer made one suggestion: | * The maintainer made one suggestion: | ||
:all looks good to me. | :all looks good to me. | ||
:One question. Are you sure you want the "int" of the answer? In the Java version everything is a float, and even in the python version xcor, ycor, and friends are floats. None of the calculations assume ints I don't think. | :One question. Are you sure you want the "int" of the answer? In the Java version everything is a float, and even in the python version xcor, ycor, and friends are floats. None of the calculations assume ints I don't think. | ||
* I made the change and did some more testing. | * I made the change and did some more testing. | ||
defprim(lc,'sqrt', 1, lambda lc,x: sqrt(x)) | |||
* next: "commit" and "push" the patch | * next: "commit" and "push" the patch | ||
git-commit -a | git-commit -a | ||