Development Team/Code Review: Difference between revisions
| Line 57: | Line 57: | ||
* For complex patches you might want to start with an overall design of the patch. | * For complex patches you might want to start with an overall design of the patch. | ||
* Make sure the submitter provided a testcase before approving the patch | * Make sure the submitter provided a testcase before approving the patch. | ||
* Make sure that [[DevelopmentTeam/API policy|API policy]] rules are respected. | |||
* Change the r? keyword to r- to indicate that the patch needs work. | * Change the r? keyword to r- to indicate that the patch needs work. | ||
* Change the r? keyword to r+ if the patch is ok to be pushed. | * Change the r? keyword to r+ if the patch is ok to be pushed. | ||