Activity Library/Editors/Reviewing Guide: Difference between revisions
| (5 intermediate revisions by 3 users not shown) | |||
| Line 1: | Line 1: | ||
{{draft}} | |||
{{ GoogleTrans-en | es =show | bg =show | zh-CN =show | zh-TW =show | hr =show | cs =show | da =show | nl =show | fi =show | fr =show | de =show | el =show | hi =show | it =show | ja =show | ko =show | no =show | pl =show | pt =show | ro =show | ru =show | sv =show }} | {{ GoogleTrans-en | es =show | bg =show | zh-CN =show | zh-TW =show | hr =show | cs =show | da =show | nl =show | fi =show | fr =show | de =show | el =show | hi =show | it =show | ja =show | ko =show | no =show | pl =show | pt =show | ro =show | ru =show | sv =show }} | ||
{{TOCright}} | {{TOCright}} | ||
| Line 47: | Line 49: | ||
Remember that your comments go to a *real person*, so try to be friendly. | Remember that your comments go to a *real person*, so try to be friendly. | ||
If you are pushing the | If you are pushing the activity public, thank the author for the time and effort they have put in. Remember that they're enhancing the usefulness and the appeal of the products! Tell them which features you like the most, and mention anywhere you think they could improve. | ||
If you are retaining in the sandbox, be polite in pointing out any problems. Provide suggestions as to what they could do or should fix before re-submitting it and encourage them to re-submit it if it could ever be public. It's also a good idea to tell the author what you liked about the extension/theme even though you've retained it. | If you are retaining in the sandbox, be polite in pointing out any problems. Provide suggestions as to what they could do or should fix before re-submitting it and encourage them to re-submit it if it could ever be public. It's also a good idea to tell the author what you liked about the extension/theme even though you've retained it. | ||
If you think it should be translated, you can add a hint for submitting it to | If you think it should be translated, you can add a hint for submitting it to the Localization Team, even if it has no locale structure. | ||
= Reviewing Activities = | = Reviewing Activities = | ||
| Line 60: | Line 61: | ||
== Step 1. Decide on Testing Scope == | == Step 1. Decide on Testing Scope == | ||
* If an activity is designated for Sugar but also can run outside of Sugar, usually, you only need to test it within Sugar | * If an activity is designated for Sugar but also can run outside of Sugar, usually, you only need to test it within Sugar | ||
* If you have Sugar running on multiple platforms, it would be great if you could do some testing on | * If you have Sugar running on multiple platforms, it would be great if you could do some testing on more than one platform (on different hardware, at different screen sizes, on different GNU/Linux distributions) | ||
* For new activities: | * For new activities: | ||
** Examine the activity for which version of Sugar it supports (focus on 0.82+) | ** Examine the activity for which version of Sugar it supports (focus on Sugar 0.82+) | ||
* For updates: | * For updates: | ||
** For activities being updated for 0.84, test on 0.84 as primary and 0.82 as secondary | ** For activities being updated for 0.84, test on 0.84 as primary and 0.82 as secondary | ||
| Line 80: | Line 81: | ||
== Step 4. Security == | == Step 4. Security == | ||
'''NOTE''': This section needs to be rewritten for the Sugar/Rainbow/Bitfrost context. | |||
=== Does it load remote JavaScript? === | === Does it load remote JavaScript? === | ||
* Deny going public. | * Deny going public. | ||
| Line 219: | Line 223: | ||
* Support questions that also contain reviews – approve | * Support questions that also contain reviews – approve | ||
[[Category:Activity]] | [[Category:Activity Team]] | ||
[[Category:HowTo]] | [[Category:HowTo]] | ||