647
edits
Changes
Jump to navigation
Jump to search
Line 51:
Line 51: − − == Reviewer guidelines == − − * For complex patches you might want to start with an overall design of the patch. − * Make sure the submitter provided a testcase before approving the patch. − * Make sure that [[Development Team/API policy|API policy]] rules are respected. − * Keep an eye on readability, we are roughly following Guido's [http://www.python.org/dev/peps/pep-0008 PEP 8] − * Change the r? keyword to r- to indicate that the patch needs work. − * Change the r? keyword to r+ if the patch is ok to be pushed.
Development Team/Code Review (view source)
Revision as of 04:45, 7 August 2009
, 04:45, 7 August 2009→Reviewer guidelines
Once your patch has received a 'r+', the reviewer will push your code to the repository. From now on your code is part of the Sugar code base and the community will maintain it for you.
Once your patch has received a 'r+', the reviewer will push your code to the repository. From now on your code is part of the Sugar code base and the community will maintain it for you.
== Push the patch ==
== Push the patch ==