647
edits
Changes
Jump to navigation
Jump to search
Line 59:
Line 59: +
Development Team/Code Review (view source)
Revision as of 10:32, 15 January 2009
, 10:32, 15 January 2009→Reviewer guidelines
* Make sure the submitter provided a testcase before approving the patch.
* Make sure the submitter provided a testcase before approving the patch.
* Make sure that [[DevelopmentTeam/API policy|API policy]] rules are respected.
* Make sure that [[DevelopmentTeam/API policy|API policy]] rules are respected.
* Keep an eye on readability, we are roughly following Guido's [http://www.python.org/dev/peps/pep-0008 PEP 8]
* Change the r? keyword to r- to indicate that the patch needs work.
* Change the r? keyword to r- to indicate that the patch needs work.
* Change the r? keyword to r+ if the patch is ok to be pushed.
* Change the r? keyword to r+ if the patch is ok to be pushed.