Changes

Activity Library/Editors/Reviewing Guide (view source)

Revision as of 21:52, 17 March 2009

805 bytes removed , 21:52, 17 March 2009

→‎Reviewing Language Packs: not applicable

Line 212: Line 212:

* The only javascript allowed is in install.js and must only be adding the dictionary (using addDirectory()). The en-US dictionary is a good example. A dictionary is not allowed to modify other settings or defaults.

−

~~== Reviewing Language Packs ==~~

+

−

A language pack is an add-on that enables support for additional language(s) in one Firefox installation. Do not confuse with locales in extensions. Language packs are typically separate XPI or JAR files that contain only locale files.

−

* Language packs should only include strings and not javascript

−

* Deny if: XML parsing errors in opening all menus, all pref-dialog panes, Error console and Add-on manager.

−

* Deny if there is any non-language pack functionality.

−

* Suggested Tools: run a completeness test using [http://lxr.mozilla.org/mozilla/source/testing/tests/l10n/scripts compare-packs]

−

* Lang packs must not break application updates, in particular they should not override the general.useragent.locale pref

−

* Language packs not passing should remain in the sandbox

= Moderating Reviews =

Walter

Bureaucrats, Administrators

10,505

edits