647
edits
Changes
Jump to navigation
Jump to search
Line 51:
Line 51: − − == Process guidelines == − Break your projects into small pieces that can be submitted for review independently. Submit for review whenever you think you need a review - you can tell that best. The reviewer will use review+ or r+ whenever the patch is accepted and ready to go into git master. − − The workflow should be something like: − * Code a small part − * Submit to review − * Push to master − * Repeat − − There will be cases when this will not be possible but we want to try to follow this guidelines. − − We could consider that 1500 lines starts to be too much for a diff, although factors like the add/delete ratio or the invasiveness of the changes should be taken in account.
Development Team/Code Review (view source)
Revision as of 03:29, 7 August 2009
, 03:29, 7 August 2009→Process guidelines
Once your patch has received a 'r+', the reviewer will push your code to the repository. From now on your code is part of the Sugar code base and the community will maintain it for you.
Once your patch has received a 'r+', the reviewer will push your code to the repository. From now on your code is part of the Sugar code base and the community will maintain it for you.
== Patch guidelines ==
== Patch guidelines ==