8,288
edits
Changes
Jump to navigation
Jump to search
Line 1:
Line 1: − + Line 25:
Line 25: − + Line 38:
Line 38: − + Line 60:
Line 60: − +
Development Team/Code Review (view source)
Revision as of 19:23, 10 March 2010
, 19:23, 10 March 2010no edit summary
<noinclude>{{ GoogleTrans-en | es =show | bg =show | zh-CN =show | zh-TW =show | hr =show | cs =show | da =show | nl =show | fi =show | fr =show | de =show | el =show | hi =show | it =show | ja =show | ko =show | no =show | pl =show | pt =show | ro =show | ru =show | sv =show }}</noinclude>{{TOCright}}
<noinclude>{{TOCright}}</noinclude>
= Introduction =
= Introduction =
* Create your patch using the 'git format-patch' command. (<code>git format-patch HEAD^</code> will create a 00xx-blahblah.patch for every commit. So don't forget to git commit!!)
* Create your patch using the 'git format-patch' command. (<code>git format-patch HEAD^</code> will create a 00xx-blahblah.patch for every commit. So don't forget to git commit!!)
* If your patch addresses an issue which is not registered in [http://dev.sugarlabs.org the Sugar Labs trac instance], please open a new ticket for it.
* If your patch addresses an issue which is not registered in [https://bugs.sugarlabs.org the Sugar Labs trac instance], please open a new ticket for it.
* Attach the patch to the ticket
* Attach the patch to the ticket
* Alternatively, you can add a link pointing to a cloned tree. Make sure it contains only the changes you propose for review.
* Alternatively, you can add a link pointing to a cloned tree. Make sure it contains only the changes you propose for review.
In order to make it easy for the reviewer please:
In order to make it easy for the reviewer please:
* note which module is effected e.g. sugar, sugar-toolkit...
* note which module is effected e.g., sugar, sugar-toolkit...
* note possible dependencies e.g. the patch is for sugar but depend on the current HEAD of sugar-toolkit which went in 5 seconds ago (see also separate section about external dependencies below)
* note possible dependencies e.g. the patch is for sugar but depend on the current HEAD of sugar-toolkit which went in 5 seconds ago (see also separate section about external dependencies below)
= Dependencies =
= Dependencies =
Dependencies need to be fulfilled on all platforms running Sugar (i.e. they need to be available at all and need to be installed which means occupying disk space), so think twice before introducing new ones. Please discuss them on [[Sugar Labs/Contacts#Developer Lists|sugar-devel]] in advance and clearly state them in the ticket. It's a always a good idea to check whether sufficiently recent versions of your proposed dependencies are already packaged for all (stable releases of the) major distributions, on '''all''' of their (semi-)supported architectures (e.g. ARM and PowerPC). If not, start requesting them (at the distribution bug trackers) ASAP and also mention it on sugar-devel and the ticket.
Dependencies need to be fulfilled on all platforms running Sugar (i.e., they need to be available at all and need to be installed which means occupying disk space), so think twice before introducing new ones. Please discuss them on [[Sugar Labs/Communication channels#Developer Lists|sugar-devel]] in advance and clearly state them in the ticket. It's a always a good idea to check whether sufficiently recent versions of your proposed dependencies are already packaged for all (stable releases of the) major distributions, on '''all''' of their (semi-)supported architectures (e.g., ARM and PowerPC). If not, start requesting them (at the distribution bug trackers) ASAP and also mention it on sugar-devel and the ticket.
[[Category:Development Team]]
[[Category:Development Team]]