Changes
→Review Process
<noinclude>{{ GoogleTrans-en | es =show | bg =show | zh-CN =show | zh-TW =show | hr =show | cs =show | da =show | nl =show | fi =show | fr =show | de =show | el =show | hi =show | it =show | ja =show | ko =show | no =show | pl =show | pt =show | ro =show | ru =show | sv =show }}</noinclude>
<noinclude>{{ GoogleTrans-en | es =show | bg =show | zh-CN =show | zh-TW =show | hr =show | cs =show | da =show | nl =show | fi =show | fr =show | de =show | el =show | hi =show | it =show | ja =show | ko =show | no =show | pl =show | pt =show | ro =show | ru =show | sv =show }}</noinclude>
= Review Process =
= Review Process =
We are using email for the review process. In the future we might change to [http://www.review-board.org/ review board] which we are currently investigating. In order to ask for a review of your code please send your patches to the Sugar [http://lists.laptop.org/listinfo/sugar mailing list].
We are using a mix of email and trac for the review process. In the future we might change to a specialized tool like [http://www.review-board.org/ review board] which we are currently investigating.
== Process guidelines ==
== Process guidelines ==
We could consider that 1500 lines starts to be too much for a diff, although factors like the add/delete ratio or the invasiveness of the changes should be taken in account.
We could consider that 1500 lines starts to be too much for a diff, although factors like the add/delete ratio or the invasiveness of the changes should be taken in account.
== Patch guidelines ==
== Patch guidelines ==
Or if the commit you want the diff of was the most-recent commit, you can do:
Or if the commit you want the diff of was the most-recent commit, you can do:
git diff HEAD^!
git diff HEAD^!
Another alternative that will give you a patch in a file called 0001-My-cool-patch.patch:
git-add new_file1 new_file2
git-commit -a -m 'My cool patch'
git-format-patch HEAD^
git-reset --hard HEAD^
== Patch submission ==
If your patch addresses an issue registered in [http://dev.laptop.org/query trac], then make sure that the ticket number is referenced in the commit comment and attach the patch to the ticket. Also, add the keyword 'r?' to call the attention of reviewers.
If your patch is a new feature and reasonably big, you may prefer to submit it for review to the Sugar [http://lists.laptop.org/listinfo/sugar mailing list].
== Email guidelines ==
In order to make it easy for the reviewer please include in your email:
* prefix your email title with [PATCH]
* try to make in the title clear what the patch is about
* note which module is effected e.g. sugar, sugar-toolkit...
* note possible dependencies e.g. the patch is for sugar but depend on the current HEAD of sugar-toolkit which went in 5 seconds ago
* note how the patch can be verified / a use case
== Reviewer guidelines ==
== Reviewer guidelines ==