Line 723: |
Line 723: |
| ||Fix indentation … | | ||Fix indentation … |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||karma conf to run unit test only | | ||karma conf to run unit test only |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||karma-shared configuration | | ||karma-shared configuration |
| |- | | |- |
Line 738: |
Line 738: |
| ||improves getObjectId's spec describe | | ||improves getObjectId's spec describe |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Grouping unit tests | | ||Grouping unit tests |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Moving toolkitContractSpect.js to functional tests directory | | ||Moving toolkitContractSpect.js to functional tests directory |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Moving datastore functional tests to separate file | | ||Moving datastore functional tests to separate file |
| |- | | |- |
Line 753: |
Line 753: |
| ||add FIXME on env.getEnvironment() | | ||add FIXME on env.getEnvironment() |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Refactor: Grouping up responsibilities in sugar mode | | ||Refactor: Grouping up responsibilities in sugar mode |
| |- | | |- |
Line 771: |
Line 771: |
| ||stub env.isStandalone = false in sugar mode | | ||stub env.isStandalone = false in sugar mode |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||datastore integration tests: increase waitFor timeout | | ||datastore integration tests: increase waitFor timeout |
| |- | | |- |
Line 780: |
Line 780: |
| ||fix false positive specs: getEnvironment when env was not set, yet | | ||fix false positive specs: getEnvironment when env was not set, yet |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Fix: functional test for envSpec | | ||Fix: functional test for envSpec |
| |- | | |- |
Line 786: |
Line 786: |
| ||Revert "Turn on debug logging" … | | ||Revert "Turn on debug logging" … |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||better semantics, test: "should run in standalone mode" | | ||better semantics, test: "should run in standalone mode" |
| |- | | |- |
Line 804: |
Line 804: |
| ||force environment to be undefined | | ||force environment to be undefined |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Refactor: common code on setup and teardown methods | | ||Refactor: common code on setup and teardown methods |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Grouping up related tests: "in sugar mode" | | ||Grouping up related tests: "in sugar mode" |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||test: should set onEnvironmentSet handler … | | ||test: should set onEnvironmentSet handler … |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||test: should run callback with null error and environment. … | | ||test: should run callback with null error and environment. … |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||js-beautify fix | | ||js-beautify fix |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||js-beautify fix | | ||js-beautify fix |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Refactor: Ensure standalone mode on "dictstore on standalone mode" de… … | | ||Refactor: Ensure standalone mode on "dictstore on standalone mode" de… … |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||dictstore save method uses isStandalone method | | ||dictstore save method uses isStandalone method |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||dictstore init uses isStandalone method | | ||dictstore init uses isStandalone method |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||Add webL10n missing definition path | | ||Add webL10n missing definition path |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||isStandalone method for env module | | ||isStandalone method for env module |
| |- | | |- |
− | |Rogelio | + | |Rogelio Mita |
| ||test: Ensure the datastore object has an objectId (datastore) | | ||test: Ensure the datastore object has an objectId (datastore) |
| |- | | |- |