Provide limits to the number of open activities and number of open instances of an activity.
- Name: Walter Bender
- Email: <walter AT sl.o>
- Targeted release: (1.02)
- Last updated: (5 November 2013)
- Percentage of completion: 100%
Set limit to open activities and open instances
At the request of OLPC AU (in an effort to reduce OOM freezes) this patch uses gconf to set a maximum number of open activities. An alert is shown if the user tries to launch more activities than the maximum asking them to close an activity before opening a new one. If maximum_number_of_open_activites is not set or == 0, then there is no maximum limit applied.
Further, Some activities don't behave well if more than one instance is open (e.g., SL #4554). This patch sets a limit on the number open instances of an activity based on a new field in activity.info: maximum_instances.
If and only if the maximum_instances field is present in activity.info, is it used to set the limit of open instances.
Benefit to Sugar
This is a feature that is already used in one major deployment. It seems to reduce OOM freezes and confusion about why activities such as Record fail when multiple copies are open.
In sugar: jarabe/desktop/homewindow.py jarabe/journal/journalactivity.py jarabe/journal/misc.py jarabe/view/launcher.py and jarabe/model/shell.py
In the toolkit: sugar3/bundle/activitybundle.py
Also impacts the activity.info file of any activity that wishes to set a limit to the number of open instances:
maximum_instances = 1
How To Test
- Add a maximum_instances field to the activity.info file of an activity
- Launch repeatedly and see if a limit is set
- From terminal gconftool-2 -t int -s /desktop/sugar/maximum_number_of_open_activities 4
- See if more than 4 activities can be launched
- From terminal gconftool-2 -u /desktop/sugar/maximum_number_of_open_activities
- See if there is any limit to the number of activities that can be launched
The direct impact on the user who have the gconf limit set is to get feedback when too many activities are launched. Activity developers can set a limit to the number of instances that can be launched.
No new dependencies
None. The feature is complete pending code review.
The gconf setting used by this feature is:
The new (optional) field in the activity.info file is:
Comments and Discussion
- See discussion tab for this feature